Skip to content

Comments

Update skillmap build to support versioned skillmap#7723

Merged
riknoll merged 7 commits intomasterfrom
shakao/skillmap-build
Dec 30, 2020
Merged

Update skillmap build to support versioned skillmap#7723
riknoll merged 7 commits intomasterfrom
shakao/skillmap-build

Conversation

@shakao
Copy link
Contributor

@shakao shakao commented Dec 14, 2020

new flow!

  • gulp skillmap in pxt to copy all files to the correct locations. this:
    • builds the skillmap
    • copies the index.html into webapp/public as skillmap.html
    • copies the built js and css into built/web/skillmap
  • build locally by running pxt skillmap --serve in the target directory
  • the previous build command (pxt skillmap in the target) is still around in case we need to deploy before we swap over to the new url

changes:

  • all skillmap assets are now permanently kept in docs/static/skillmap
  • added npm prebuild and postbuild commands to generate an index.html formatted to our specifications (don't remove comments, don't collapse whitespace), so the backend replacements should all work
  • added the skillmap url to the webconfig

for microsoft/pxt-arcade#2584

@shakao shakao requested review from jwunderl and riknoll December 14, 2020 19:51
Copy link
Member

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add build instructions to the read me.

@pelikhan pelikhan self-requested a review December 14, 2020 21:42
@pelikhan
Copy link
Member

Does the pxt ci run gulp skillmap as part of the build?

@shakao
Copy link
Contributor Author

shakao commented Dec 15, 2020

yep! although it doesn't have to, i can take it out for now since the backend route changes aren't in either

@pelikhan
Copy link
Member

pelikhan commented Dec 15, 2020 via email

@riknoll riknoll self-assigned this Dec 16, 2020
@riknoll
Copy link
Member

riknoll commented Dec 30, 2020

@pelikhan can you mark your changes as resolved?

@riknoll riknoll merged commit b9825c5 into master Dec 30, 2020
@riknoll riknoll deleted the shakao/skillmap-build branch December 30, 2020 19:00
@riknoll
Copy link
Member

riknoll commented Dec 30, 2020

thanks!

shakao added a commit that referenced this pull request Jan 7, 2021
* Update skillmap build to support versioned skillmap

* Add npm install command to skillmap build

* Add README with skillmap build documentation

* Path paths for generated JS/CSS files

* Pin versions of react, redux, typescript to match pxt versions

* Disable eslint in webpack

* Add skillmap to tslint, fix linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants