Update skillmap build to support versioned skillmap#7723
Merged
Conversation
pelikhan
requested changes
Dec 14, 2020
Member
pelikhan
left a comment
There was a problem hiding this comment.
Please add build instructions to the read me.
Member
|
Does the pxt ci run gulp skillmap as part of the build? |
Contributor
Author
|
yep! although it doesn't have to, i can take it out for now since the backend route changes aren't in either |
Member
riknoll
approved these changes
Dec 15, 2020
jwunderl
approved these changes
Dec 15, 2020
Member
|
@pelikhan can you mark your changes as resolved? |
pelikhan
approved these changes
Dec 30, 2020
Member
|
thanks! |
shakao
added a commit
that referenced
this pull request
Jan 7, 2021
* Update skillmap build to support versioned skillmap * Add npm install command to skillmap build * Add README with skillmap build documentation * Path paths for generated JS/CSS files * Pin versions of react, redux, typescript to match pxt versions * Disable eslint in webpack * Add skillmap to tslint, fix linting errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new flow!
gulp skillmapin pxt to copy all files to the correct locations. this:webapp/publicasskillmap.htmlbuilt/web/skillmappxt skillmap --servein the target directorypxt skillmapin the target) is still around in case we need to deploy before we swap over to the new urlchanges:
docs/static/skillmapfor microsoft/pxt-arcade#2584