Chaning the name from kindscript to makecode#8712
Merged
Conversation
Member
|
Can you ask crowdin for a redirect? |
Collaborator
Author
|
Yes we should ask that too. |
Collaborator
Author
|
@anzhou5 can you ask if they can do redirect if anyone tries to reach kindscript to new URL? |
jwunderl
approved these changes
Feb 11, 2022
Member
jwunderl
left a comment
jwunderl
left a comment
There was a problem hiding this comment.
I believe there's an env variable in the backend (CROWDIN_PROJECT) set to kindscript as well that gets used when only when initializing a page for inContextTranslationMode (in serveFileAsync
in routing.ts)
Collaborator
Author
|
@jwunderl is that part of env.json? |
Member
|
Yes, it's in env.json |
Collaborator
Author
|
Ideally it should be in pxt-deployment-config. It is not a secret. |
ganicke
approved these changes
Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation and other changes for prepping name change.