Conversation
Contributor
Author
|
@riknoll The changes I made to the build process look more extensive than they really are. I did some refactoring so that skillmap, authcode, and multiplayer share a build framework. The duplication was getting a bit much. Hopefully it all "just works" as before. |
jwunderl
approved these changes
Oct 3, 2022
jwunderl
reviewed
Oct 3, 2022
riknoll
approved these changes
Oct 3, 2022
Member
riknoll
left a comment
riknoll
left a comment
There was a problem hiding this comment.
LGTM, but missing a lot of localized string in join/host game files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a basic multiplayer client app skeleton, with gulp build support.
Please see the
multiplayer/README.mdfor more information.