Skip to content

Comments

Fixes bug with loading help resources (side docs) on Python methods#9136

Merged
kimprice merged 2 commits intomasterfrom
kim-help-resource
Oct 21, 2022
Merged

Fixes bug with loading help resources (side docs) on Python methods#9136
kimprice merged 2 commits intomasterfrom
kim-help-resource

Conversation

@kimprice
Copy link
Contributor

@kimprice kimprice merged commit be78a45 into master Oct 21, 2022
@kimprice kimprice deleted the kim-help-resource branch October 21, 2022 18:28
@abchatra
Copy link
Collaborator

Looks good. Add bit more description about the root cause and the fix if possible here.

@kimprice
Copy link
Contributor Author

As we build the AST from the user's Python code we make several passes to gather all the information at each node. After the last pass we mark the node with all the information like the position, symbols, etc. Before this fix, we weren't marking the node at the last pass for method names. Then when trying to load help resources, there were no symbols to iterate through to find any corresponding help URL.

@riknoll Am I explaining this correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No help for "set_flag" in python editor

4 participants