Fixes bug with loading help resources (side docs) on Python methods#9136
Merged
Fixes bug with loading help resources (side docs) on Python methods#9136
Conversation
riknoll
approved these changes
Oct 21, 2022
jwunderl
approved these changes
Oct 21, 2022
Collaborator
|
Looks good. Add bit more description about the root cause and the fix if possible here. |
Contributor
Author
|
As we build the AST from the user's Python code we make several passes to gather all the information at each node. After the last pass we mark the node with all the information like the position, symbols, etc. Before this fix, we weren't marking the node at the last pass for method names. Then when trying to load help resources, there were no symbols to iterate through to find any corresponding help URL. @riknoll Am I explaining this correctly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes microsoft/pxt-arcade#2149