Update --asseteditor page to support all asset types#9255
Merged
Conversation
riknoll
requested review from
abchatra,
eanders-ms,
jwunderl,
kimprice and
thsparks
Member
Author
|
Also, I should mention, the only thing currently using the --asseteditor page is https://shakao.github.io/arcade-sprite-pack/ so this won't break anyone. |
jwunderl
approved these changes
Dec 1, 2022
Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the --asseteditor page to support all asset types.
The messaging protocol for editing/creating/duplicating assets now takes the entire project filesystem as an argument. This way, all the logic for managing assets and emitting TS files can stay inside the iframe and the outside window doesn't need to take a direct dependency on pxtlib. As a bonus, this also means we can send all of the pxt_modules for a project so the galleries are actually populated now instead of empty.