Add iOS and Android as pythonPlatform#11221
Conversation
There was a problem hiding this comment.
Seems like someone beat me to this even before I started working on this yesterday (should have searched in open PRs). Have provided some feedback, please do give a look.
Also while we are at it, why not also also apply the following patch for auto detection of android platform on Android. Node.js is supported as an experimental platform on Android, and there is a significant amount of work I've done to ensure that Node.js works well on Android (inside Termux specifically):
diff --git a/packages/pyright-internal/src/common/fullAccessHost.ts b/packages/pyright-internal/src/common/fullAccessHost.ts
index b8adae491..f881b25b5 100644
--- a/packages/pyright-internal/src/common/fullAccessHost.ts
+++ b/packages/pyright-internal/src/common/fullAccessHost.ts
@@ -58,6 +58,8 @@ export class LimitedAccessHost extends NoAccessHost {
return PythonPlatform.Linux;
} else if (process.platform === 'win32') {
return PythonPlatform.Windows;
+ } else if (process.platform === 'android') {
+ return PythonPlatform.Android;
}
return undefined;56eacb3 to
50d87b4
Compare
|
There has been no response from an maintainer to this PR for a month. @rchiodo I've seen that you're doing a lot in this repo now, so I'm contacting you directly. Is there anything that is blocking this PR? Or is there anything I can do to help this PR getting merged? |
|
LGTM |
Fixes #10752