Skip to content

Add iOS and Android as pythonPlatform#11221

Merged
rchiodo merged 1 commit intomicrosoft:mainfrom
timrid:pythonplatform-ios-and-android
Feb 17, 2026
Merged

Add iOS and Android as pythonPlatform#11221
rchiodo merged 1 commit intomicrosoft:mainfrom
timrid:pythonplatform-ios-and-android

Conversation

@timrid
Copy link
Copy Markdown
Contributor

@timrid timrid commented Jan 10, 2026

Fixes #10752

Copy link
Copy Markdown

@thunder-coding thunder-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like someone beat me to this even before I started working on this yesterday (should have searched in open PRs). Have provided some feedback, please do give a look.

Also while we are at it, why not also also apply the following patch for auto detection of android platform on Android. Node.js is supported as an experimental platform on Android, and there is a significant amount of work I've done to ensure that Node.js works well on Android (inside Termux specifically):

diff --git a/packages/pyright-internal/src/common/fullAccessHost.ts b/packages/pyright-internal/src/common/fullAccessHost.ts
index b8adae491..f881b25b5 100644
--- a/packages/pyright-internal/src/common/fullAccessHost.ts
+++ b/packages/pyright-internal/src/common/fullAccessHost.ts
@@ -58,6 +58,8 @@ export class LimitedAccessHost extends NoAccessHost {
             return PythonPlatform.Linux;
         } else if (process.platform === 'win32') {
             return PythonPlatform.Windows;
+        } else if (process.platform === 'android') {
+            return PythonPlatform.Android;
         }
 
         return undefined;

Comment thread packages/pyright-internal/src/analyzer/staticExpressions.ts Outdated
@timrid timrid force-pushed the pythonplatform-ios-and-android branch from 56eacb3 to 50d87b4 Compare January 15, 2026 18:28
@timrid
Copy link
Copy Markdown
Contributor Author

timrid commented Feb 14, 2026

There has been no response from an maintainer to this PR for a month. @rchiodo I've seen that you're doing a lot in this repo now, so I'm contacting you directly. Is there anything that is blocking this PR? Or is there anything I can do to help this PR getting merged?

@rchiodo
Copy link
Copy Markdown
Collaborator

rchiodo commented Feb 17, 2026

LGTM

@rchiodo rchiodo merged commit 1bec65c into microsoft:main Feb 17, 2026
1 check passed
@timrid timrid deleted the pythonplatform-ios-and-android branch March 17, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Android and iOS

3 participants