This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Add ability to get document content from API#103
Merged
MikhailArkhipov merged 3 commits intomicrosoft:masterfrom Sep 18, 2018
MikhailArkhipov:enc
Merged
Add ability to get document content from API#103MikhailArkhipov merged 3 commits intomicrosoft:masterfrom MikhailArkhipov:enc
MikhailArkhipov merged 3 commits intomicrosoft:masterfrom
MikhailArkhipov:enc
Conversation
|
|
||
| public Dictionary<object, object> Properties { get; } = new Dictionary<object, object>(); | ||
|
|
||
| public IDocument Document => this as IDocument; |
Contributor
There was a problem hiding this comment.
public IDocument Document => this doesn't work?
|
|
||
| completions.Should().HaveItem("append") | ||
| .Which.Should().HaveInsertText("append(self, value):\r\n\treturn super(oar, self).append(value)"); | ||
| .Which.Should().HaveInsertText("append(self, value):\r\n return super(oar, self).append(value)"); |
Contributor
There was a problem hiding this comment.
How do we determine if it is a \t or a set of spaces? Is there a setting for it?
Author
There was a problem hiding this comment.
Per GetCompletionsForOverride it always uses spaces. I believe per PEP spaces are strongly preferred.
AlexanderSher
approved these changes
Sep 18, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Add ability to get document content from API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And few more useful things to extensibility interfaces