This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix References_Parameters_NestedFunction#118
Merged
MikhailArkhipov merged 1 commit intomicrosoft:masterfrom Sep 20, 2018
MikhailArkhipov:master
Merged
Fix References_Parameters_NestedFunction#118MikhailArkhipov merged 1 commit intomicrosoft:masterfrom MikhailArkhipov:master
MikhailArkhipov merged 1 commit intomicrosoft:masterfrom
MikhailArkhipov:master
Conversation
| if (defScope == null) { | ||
| variables = _unit.State.BuiltinModule.GetDefinitions(name.Name) | ||
| .SelectMany(ToVariables); | ||
| if (!scope.EnumerateTowardsGlobal.Any()) { |
Contributor
There was a problem hiding this comment.
We don't need to call EnumerateTowardsGlobal.Any(), it should be enough to check after the foreach if variables is empty.
Author
There was a problem hiding this comment.
I am not sure it would be same thing. Any means there are no scopes so we should fetch from global. No variables may mean there are scopes but nothing was found.
AlexanderSher
approved these changes
Sep 20, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Fix References_Parameters_NestedFunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39