This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix string concatenation spacing in line formatter#144
Merged
jakebailey merged 1 commit intomicrosoft:masterfrom Sep 27, 2018
Merged
Fix string concatenation spacing in line formatter#144jakebailey merged 1 commit intomicrosoft:masterfrom
jakebailey merged 1 commit intomicrosoft:masterfrom
Conversation
|
|
||
| case TokenKind.Name: | ||
| case TokenKind.Constant: | ||
| if (token.IsString && next != null && next.IsString) { |
Contributor
There was a problem hiding this comment.
Does next == null means that it is the last token?
Also, do you need to check if they are on the same line?
Member
Author
There was a problem hiding this comment.
Yes, that next would be null if the current token were the last token on the line. That next is pulled from the list of tokens of the line, not the linked-list that's happening in TokenExt which could peer forward. I wouldn't want to look at the next line, since even if the next token (ignoring whitespace) happens to be a string literal, the fact that it's on another line implies that there's already spacing and adding a space here would only be adding trailing whitespace (which would then be trimmed away).
MikhailArkhipov
approved these changes
Sep 27, 2018
jakebailey
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought of this case while reading the fstring spec. The line formatter defaults to not spacing around string literals, but it's likely better to insert a space between two string literals next to each other.
For reference:
'a''b'and'a' 'b'would not be changed (even with more than one space between). I could emulate this behavior in the line formatter, sinceTokenExtincludesPreceedingWhitespace.'with").