This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Prevent document reload with old content #1585
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found another case of buffer corruption. Happens when module reload comes during analysis. Repro:
blackformatter if you have one installed.scikit-learnconftest.pydel sys._is_pytest_sessionblacksay yes.The buffer is now corrupted since changes comes over content reloaded by
ReloadAll.ResetintoPopulate,MarkChangedandClear.Populateonly happens once and there is noUpdateafterClear.MarkChangedadvances version so analysis thinks buffer has changed without actually reloading it.