This repository was archived by the owner on Apr 14, 2022. It is now read-only.
[WIP] Prevent document reload with old content #1590
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1543
Sligtly different from #1585.
Found another case of buffer corruption. Happens when module reload comes during analysis.
Repro:
scikit-learnconftest.pydel sys._is_pytest_sessionReloadAll.Separated
ResetintoSetContent,MarkChangedandClear.Added exceptions to make sure Populate only happens once and there is no
UpdateafterClear.MarkChangedadvances version so analysis thinks buffer has changed without actually reloading it.