This repository was archived by the owner on Apr 14, 2022. It is now read-only.
RELEASE: Restore path watching fix lost in merges#171
Merged
MikhailArkhipov merged 1 commit intomasterfrom Sep 30, 2018
Merged
Conversation
MikhailArkhipov
commented
Sep 30, 2018
MikhailArkhipov
commented
- Apparently new code was never called. Old code remained despite new function exists.
- Fix issue in throttling
MikhailArkhipov
changed the title
| private void TimerProc(object o) { | ||
| lock (_lock) { | ||
| if (_changedSinceLastTick) { | ||
| if (!_changedSinceLastTick) { |
Contributor
There was a problem hiding this comment.
I believe the old comparison was correct.
Otherwise it's not clear why later _changedSinceLastTick is set to false.
Author
There was a problem hiding this comment.
It is throttling. Flag tells when there were no changes since last timer tick - i.e. multiple file change activity (such as installation of a large package) is over and it is time to reload modules. In fact, I am thinking 500 ms is too low.
AlexanderSher
approved these changes
Sep 30, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
RELEASE: Restore path watching fix lost in merges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.