This repository was archived by the owner on Apr 14, 2022. It is now read-only.
add refactoring and add code action setting support#1734
Merged
Conversation
bschnurr
reviewed
Nov 1, 2019
Author
|
ping @jakebailey @MikhailArkhipov @bschnurr @judej @RaymonGulati1 can you do code review for this PR? |
jakebailey
reviewed
Nov 8, 2019
| var quickfix = new Dictionary<string, object>(); | ||
|
|
||
| var refactoringToken = pythonSection["refactoring"]; | ||
| var quickfixToken = pythonSection["quickfix"]; |
Member
There was a problem hiding this comment.
quickfix or quickFix? Where are these settings coming from?
Author
There was a problem hiding this comment.
it is coming from settings.json.
ex) "python.quickfix.addimport": false
no UI. just a way to pass setting
Member
There was a problem hiding this comment.
Right, I was just wondering if @Anapo14 had looked at the naming ahead of time.
Member
There was a problem hiding this comment.
quickfix is probably fine. I just wanted to ensure we had a standardized name.
… since that is what LSP uses.
|
LGTM, @jakebailey ? |
jakebailey
reviewed
Nov 8, 2019
Author
|
@MikhailArkhipov so you okay except the option name? |
Author
|
any feedback from other people? |
jakebailey
approved these changes
Nov 8, 2019
Author
|
thank you! |
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
* add refactoring and add code action setting support * some clean up * added test on add import being turned off * removed comment not relevant anymore * removed empty trailing spaces * changed code to use quickFix. user facing setting is left as quickfix since that is what LSP uses. * removed using try/catch * cancellation check inside of the loop * added timeout * updated doc comment * more doc comment update * more doc comment update (cherry picked from commit 75cecfb)
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
* add refactoring and add code action setting support * some clean up * added test on add import being turned off * removed comment not relevant anymore * removed empty trailing spaces * changed code to use quickFix. user facing setting is left as quickfix since that is what LSP uses. * removed using try/catch * cancellation check inside of the loop * added timeout * updated doc comment * more doc comment update * more doc comment update (cherry picked from commit 75cecfb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is no refactoring provider yet. just plumbing code to enable it on vscode/lsp.
added a plumbing code for codeaction settings.
one can add in settings.json
"python.refactoring.xxx" or "python.quickfix.xxx" and use CodeActionSettings.ReadOption("xxx") to read value.
added hidden "python.quickfix.addimports" for add import feature.