This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix References_GrammarTest_Statements#189
Merged
MikhailArkhipov merged 3 commits intomicrosoft:masterfrom Oct 3, 2018
MikhailArkhipov:40
Merged
Fix References_GrammarTest_Statements#189MikhailArkhipov merged 3 commits intomicrosoft:masterfrom MikhailArkhipov:40
MikhailArkhipov merged 3 commits intomicrosoft:masterfrom
MikhailArkhipov:40
Conversation
|
|
||
| // External module 'abc', URI varies depending on install | ||
| var externalUri = references[1].uri; | ||
| externalUri.LocalPath.Should().Contain("abc.py"); |
| .Where(v => (v.VariableType == VariableType.Reference || v.VariableType == VariableType.Value) && | ||
| v.ScopeLevel <= mainDefinition.ScopeLevel); | ||
| variables = new[] { mainDefinition }.Concat(others.Concat(defsToRefs)); | ||
| variables = new[] { mainDefinition }.Concat(imports).Concat(others.Concat(defsToRefs)); |
Contributor
There was a problem hiding this comment.
Is it just rearrangement, or some of the variables will be excluded?
Author
There was a problem hiding this comment.
No exclusion, just keeping imports as definitions. Before they were converted to references since they were below in the same scope such as
abc = 1
import abc
AlexanderSher
approved these changes
Oct 3, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Fix References_GrammarTest_Statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40
Code is pretty confusing, with reassignments and import names same as variable names. Various apps behave differently. Basically the fix is
import abcas reference (so use can find all usages of 'abc').