Add double-factorized chemistry sample#1033
Merged
Merged
Conversation
Co-Authored-By: Mathias Soeken <mathias.soeken@microsoft.com> Co-Authored-By: Aarthi Sundaram <59100950+aarthims@users.noreply.github.com>
tcNickolas
requested review from
DmitryVasilevsky,
cesarzc,
sezna and
swernli
as code owners
Benchmark for dbc91c0Click to view benchmark
|
Collaborator
|
The test failure is unfortunately expected, but @sezna is already working on a fix! There is automated logic that tries to build samples, but it doesn't know how to build multi-file projects yet. |
msoeken
requested changes
Jan 18, 2024
Member
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
Looks good to me. I left some comments.
Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
Benchmark for a7eb214Click to view benchmark
|
billti
reviewed
Jan 18, 2024
billti
reviewed
Jan 18, 2024
Benchmark for 9ed471cClick to view benchmark
|
Benchmark for f73c336Click to view benchmark
|
msoeken
approved these changes
Jan 18, 2024
Member
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
All my comments have been addressed.
ivanbasov
approved these changes
Jan 18, 2024
Contributor
|
Once #1040 goes in, this multi-file sample should work. |
Benchmark for 79e65ccClick to view benchmark
|
swernli
approved these changes
Jan 19, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.