Skip to content

[Missing API] Added BigIntAsBoolArray #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swernli merged 4 commits into from
Jan 22, 2024
Merged

[Missing API] Added BigIntAsBoolArray #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50319d9
added BoolArrayAsBigInt function
filipw Jan 19, 2024
691864d
added tests for BoolArrayAsBigInt and BigIntAsBoolArray
filipw Jan 19, 2024
e3f4c6b
Merge branch 'main' of https://github.com/microsoft/qsharp into main4
filipw Jan 21, 2024
05fb517
await on create comment
filipw Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ jobs:
script: |
if (${{ env.BRANCH_MEASUREMENT }} !== ${{ env.MAIN_MEASUREMENT }}) {
try {
github.rest.issues.createComment({
await github.rest.issues.createComment({
Comment thread
swernli marked this conversation as resolved.
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down
150 changes: 149 additions & 1 deletion library/src/tests/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

#![allow(clippy::too_many_lines)]
use super::test_expression;
use qsc::interpret::Value;

Expand Down Expand Up @@ -30,6 +30,154 @@ fn check_int_as_bool_array() {
);
}

#[test]
fn check_bigint_as_bool_array() {
test_expression(
"Microsoft.Quantum.Convert.BigIntAsBoolArray(18446744073709551616L, 128)", // note: 18446744073709551616L == 2^64
&Value::Array(
vec![
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(true),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
Value::Bool(false),
]
.into(),
),
);
}

#[test]
fn check_bool_array_as_big_int() {
test_expression(
"Microsoft.Quantum.Convert.BoolArrayAsBigInt([false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, true, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false])",
&Value::BigInt(18_446_744_073_709_551_616_u128.into()),
);
}

#[test]
fn check_result_array_as_int() {
test_expression(
Expand Down
26 changes: 26 additions & 0 deletions library/std/convert.qs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,32 @@ namespace Microsoft.Quantum.Convert {
result
}

/// # Summary
/// Converts an array of Boolean values into a non-negative BigInt, interpreting the
/// array as a binary representation in little-endian format.
///
/// # Input
/// ## boolArray
/// An array of Boolean values representing the binary digits of a BigInt.
///
/// # Output
/// A BigInt represented by `boolArray`.
///
/// # Remarks
/// The function interprets the array in little-endian format, where the first
/// element of the array represents the least significant bit.
/// The input `boolArray` should not be empty.
function BoolArrayAsBigInt(boolArray : Bool[]) : BigInt {
mutable result = 0L;
for i in 0..Length(boolArray) - 1 {
if boolArray[i] {
set result += 1L <<< i;
}
}

result
}

/// # Summary
/// Produces a binary representation of a non-negative BigInt, using the
/// little-endian representation for the returned array.
Expand Down