Skip to content

Ignore failed PR comment when PRs are from forks#1050

Merged
swernli merged 7 commits into
microsoft:mainfrom
orpuente-MS:main
Jan 19, 2024
Merged

Ignore failed PR comment when PRs are from forks#1050
swernli merged 7 commits into
microsoft:mainfrom
orpuente-MS:main

Conversation

@orpuente-MS
Copy link
Copy Markdown
Contributor

github.rest.issues.createComment({ ... }) is throwing an error when running the memory profile on PRs from forks. We want to treat this failure as warning instead of an error.

Comment thread .github/workflows/ci.yml Outdated
Co-authored-by: Alex Hansen <alex@alex-hansen.com>
@orpuente-MS orpuente-MS changed the title Memory bench fails on PRs from forks Ignore failed PR comment when PRs are from forks Jan 19, 2024
@orpuente-MS orpuente-MS marked this pull request as ready for review January 19, 2024 22:54
@swernli swernli enabled auto-merge January 19, 2024 22:54
@swernli swernli added this pull request to the merge queue Jan 19, 2024
Merged via the queue into microsoft:main with commit 602c0a6 Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants