Update spans used for some type mismatch errors#1098
Merged
Conversation
This change adds some additonal logic to better select error spans and expected/actual types for both if-expressions and callable blocks. Fixes #970
swernli
commented
Jan 31, 2024
Collaborator
Author
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
See screenshots and discussion in linked issue for more context
Benchmark for 7495a6eClick to view benchmark
|
sezna
approved these changes
Feb 1, 2024
minestarks
approved these changes
Feb 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds some additonal logic to better select error spans and expected/actual types for both if-expressions and callable blocks.
Fixes #970