Skip to content

Session now exits when there is a runtime failure when running without debugging #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idavis merged 2 commits into from
Feb 2, 2024
Merged

Session now exits when there is a runtime failure when running without debugging #1103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
defa471
Session now exits when there is a runtime failure when running withou…
idavis Feb 1, 2024
9ac7f4f
Simplify logic
idavis Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions vscode/src/debugger/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,14 +390,20 @@ export class QscDebugSession extends LoggingDebugSession {
// This will be replaced when the interpreter
// supports shots.
for (let i = 0; i < args.shots; i++) {
const result = await this.debugService.evalContinue(
bps,
this.eventTarget,
);
if (result.id != StepResultId.Return) {
await this.endSession(`execution didn't run to completion`, -1);
try {
const result = await this.debugService.evalContinue(
bps,
this.eventTarget,
);
if (result.id != StepResultId.Return) {
await this.endSession(`execution didn't run to completion`, -1);
return;
}
} catch (e) {
await this.endSession(`ending session due to error: ${e}`, 1);
return;
}

this.writeToDebugConsole(`Finished shot ${i + 1} of ${args.shots}`);
// Reset the interpreter for the next shot.
// The interactive interpreter doesn't do this automatically,
Expand Down