Formatter: Remove Unauthoritative Newlines#1303
Merged
Merged
Conversation
|
Change in memory usage detected by benchmark. Memory Report for 3fe761e
|
This reverts commit e31fe37.
|
Change in memory usage detected by benchmark. Memory Report for 4d93cad
|
Benchmark for 4d93cadClick to view benchmark
|
|
Change in memory usage detected by benchmark. Memory Report for 19ca37b
|
Benchmark for 19ca37bClick to view benchmark
|
|
Change in memory usage detected by benchmark. Memory Report for e956af8
|
Benchmark for e956af8Click to view benchmark
|
|
Change in memory usage detected by benchmark. Memory Report for bdc9c4e
|
Benchmark for bdc9c4eClick to view benchmark
|
ScottCarda-MS
changed the title
ScottCarda-MS
requested review from
DmitryVasilevsky,
billti,
cesarzc,
idavis,
minestarks,
sezna and
swernli
as code owners
Open
DmitryVasilevsky
approved these changes
Mar 25, 2024
Contributor
DmitryVasilevsky
left a comment
DmitryVasilevsky
left a comment
There was a problem hiding this comment.
Approving library part with comments.
minestarks
reviewed
Mar 25, 2024
minestarks
reviewed
Mar 25, 2024
minestarks
reviewed
Mar 25, 2024
minestarks
reviewed
Mar 25, 2024
Member
minestarks
left a comment
minestarks
left a comment
There was a problem hiding this comment.
Very satisfying to see all the ad-hoc formatting standardized in the libraries! Definite improvement IMO.
I don't have an opinion either way on the subjective calls (e.g. spaces around certain binary operators).
Just a couple of requests, will sign off when those are addressed.
|
Change in memory usage detected by benchmark. Memory Report for 740789d
|
Benchmark for 740789dClick to view benchmark
|
minestarks
approved these changes
Mar 26, 2024
|
Change in memory usage detected by benchmark. Memory Report for 6b38c18
|
Benchmark for 6b38c18Click to view benchmark
|
|
Change in memory usage detected by benchmark. Memory Report for cf6cf17
|
Benchmark for cf6cf17Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unauthoritative newlines from the formatter, ensuring that all newlines are strictly enforced between either a single style or one of several well-defined styles.
This PR also contains all the formatted Samples and Libraries Q# files.