Fixes Magic Getting Erased by Format in Notebooks#1310
Merged
Conversation
fixed bug in notebooks
Benchmark for c80daabClick to view benchmark
|
Benchmark for bef7150Click to view benchmark
|
sezna
reviewed
Mar 26, 2024
Contributor
sezna
left a comment
There was a problem hiding this comment.
Maybe a dumb question, but looking at the test, does this end up replacing %%qsharp with //qsharp in notebooks?
Contributor
Author
No, the text found in the notebook is only changed by the edits the formatter makes. Since there is nothing wrong format-wise with |
minestarks
reviewed
Mar 26, 2024
minestarks
approved these changes
Mar 26, 2024
Benchmark for 12728e9Click to view benchmark
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
Fix regression in #1310 Bug:  Fix:  
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was caused by two different bugs that are addressed in this PR:
\r\nline endings, the raw token lexer would only consider the\nline ending, resulting in comment tokens with trailing\rcharacters in them.In order to preserve the magic command in the notebooks from getting removed as leading whitespace in a file (a formatter rule), the magic command is replaced by a comment instead of whitespace.
Fixes #1308