Add tasks 1.8, 1.9, 1.10 to Superposition Kata#1346
Merged
tcNickolas merged 23 commits intoApr 2, 2024
Conversation
added 6 commits
March 26, 2024 17:12
…sition-ghz-allbasis
…sition-ghz-allbasis
jkingdon-ms
requested review from
DmitryVasilevsky,
billti,
cesarzc,
sezna,
swernli and
tcNickolas
as code owners
tcNickolas
suggested changes
Apr 1, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
I took a look and left some suggestions; now that we're getting into more interesting tasks, there is a bit of extra work in the tests and in rewording the solutions to account for not reusing images.
Thank you!
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…s/qsharp into katas/superposition-18-19-110
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…on.md Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…s/qsharp into katas/superposition-18-19-110
tcNickolas
suggested changes
Apr 2, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
I took another look, looks great, just a few minor comments left. Thank you!
…on.md Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…on.md Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
added 2 commits
April 2, 2024 17:09
…s/qsharp into katas/superposition-18-19-110
tcNickolas
approved these changes
Apr 2, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks great, thank you!
tcNickolas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves part of #1185 .