Add global phase -1, relative phase i, and complex relative phase tasks to Single-Qubit Gates kata#1369
Merged
Merged
Conversation
WWhitedogi
requested review from
DmitryVasilevsky,
billti,
cesarzc,
sezna,
swernli and
tcNickolas
as code owners
tcNickolas
suggested changes
Apr 9, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks good overall, I went through and left some formatting comments.
Thank you!
tcNickolas
reviewed
Apr 9, 2024
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Contributor
|
Can you let me know when this PR is ready for another round of review? Just leave a comment or "request review" so that I know to look at it again. Thank you! |
tcNickolas
approved these changes
Apr 11, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks good! (And nice solution explanation rewrite!)
I left some formatting suggestions, but I should be able to click through them to accept them without you doing that before merging.
Thank you!
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
tcNickolas
reviewed
Apr 11, 2024
tcNickolas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add task phase_flip, phase_change, global phase_change to Single Qubit Gates