Add tasks 1.11, 1.12 to Superposition Kata#1381
Merged
tcNickolas merged 10 commits intoApr 15, 2024
Merged
Conversation
added 5 commits
March 26, 2024 17:12
jkingdon-ms
requested review from
DmitryVasilevsky,
billti,
cesarzc,
sezna,
swernli and
tcNickolas
as code owners
tcNickolas
suggested changes
Apr 13, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks good, just a couple of suggestions on improving tests and formatting.
Thank you!
frtibble
reviewed
Apr 13, 2024
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…qsharp into katas/superposition-111-112
tcNickolas
approved these changes
Apr 15, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks great, just two minor comments (updated the links to the docs but forgot to update the function names themselves), I might be able to apply the suggestions myself.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves part of #1185 .