Adds task 1.13 to Superposition Kata#1382
Conversation
|
Let me know when this is ready for review! |
Co-authored-by: James Kingdon <96249042+jkingdon-ms@users.noreply.github.com>
Co-authored-by: James Kingdon <96249042+jkingdon-ms@users.noreply.github.com>
frtibble
requested review from
DmitryVasilevsky,
billti,
cesarzc,
sezna,
swernli and
tcNickolas
as code owners
|
Thank you @jkingdon-ms for the helpful feedback, @tcNickolas tagging you as it is ready for review! |
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
This change has quite a few build errors that CI build doesn't catch because this kata is not added to the katas/content/index.json file. We usually add this kata to the index when we work on it, so that it shows up in local tests and playground for us to play with and the CI build can verify it, and then in the very last iteration remove it so that it doesn't get published prematurely.
Thank you!
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
|
The CI build still fails. Did you try to build the new task locally in the playground? This helps to figure our build issues a lot |
|
Hi Mariia, I've pushed a few more changes now which hopefully address the remaining comments, let me know if anything needs tweaking |
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks great, only few minor edits!
Thank you!
3 participants
Part of #1185