Add tasks on Bell states changes to Multi-Qubit States kata#1385
Merged
Conversation
WWhitedogi
requested review from
DmitryVasilevsky,
billti,
cesarzc,
sezna,
swernli and
tcNickolas
as code owners
tcNickolas
suggested changes
Apr 15, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
I left some comments, the biggest change is that we need to use a different approach to testing this, since we're looking neither at state preparation like in other tasks in this kata nor at unitary implementation like in the Single-Qubit Gates kata.
Thank you!
…der.qs Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…der.qs Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
WWhitedogi
commented
Apr 17, 2024
Contributor
Author
WWhitedogi
left a comment
WWhitedogi
left a comment
There was a problem hiding this comment.
Add one more section(new lesson) in index.md file, update the verification file for BellStateChange1to3.
Delete the description of another potential case, since there's no change after update the verification method.
tcNickolas
suggested changes
Apr 18, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks much better, and the test outputs look great! Just a few more formatting suggestions, and should be good to go.
I've also realized that we use inconsistent names for Bell states - lower case Greek letters in the Dirac notation section and upper case in the exercises. I think they're more commonly referred to in upper case. Since you're working with this kata already, could you please update the names in the Dirac notation section?
Thank you!
tcNickolas
changed the title
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…tion.qs Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
1. Standardize indentation across all exercise sections. 2. Change Bell state names in the Dirac notation section to uppercase. 3. Move the "Modifying Entangled States" section to just before the conclusion.
Add "Message("Incorrect");"
Add "Message("Incorrect");"
tcNickolas
approved these changes
Apr 19, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.