Update doc comments in std library#1401
Merged
Merged
Conversation
|
Change in memory usage detected by benchmark. Memory Report for f9e9b3a
|
|
Change in memory usage detected by benchmark. Memory Report for 0146433
|
Benchmark for 0146433Click to view benchmark
|
|
Change in memory usage detected by benchmark. Memory Report for 6c2e873
|
Benchmark for 6c2e873Click to view benchmark
|
|
Change in memory usage detected by benchmark. Memory Report for 352efc7
|
ScottCarda-MS
approved these changes
Apr 18, 2024
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Looks good from a pass from me, but it would be easy to miss something so best to have several more reviewers.
Benchmark for 352efc7Click to view benchmark
|
Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com>
|
Change in memory usage detected by benchmark. Memory Report for 6186348
|
Benchmark for 6186348Click to view benchmark
|
cesarzc
reviewed
Apr 19, 2024
cesarzc
approved these changes
Apr 19, 2024
Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
|
Change in memory usage detected by benchmark. Memory Report for 3a496d9
|
Benchmark for 3a496d9Click to view benchmark
|
swernli
approved these changes
Apr 20, 2024
Collaborator
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
This is great, thanks Dmitry!
sezna
approved these changes
Apr 22, 2024
|
Change in memory usage detected by benchmark. Memory Report for ca373d7
|
Benchmark for ca373d7Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates doc comments in the standard library. It also adds information to the readme file describing what to put in different sections of doc comments.
This is mostly random updates to a few spots in the library rather than a consistent sweep over all functions and operation. Mostly to solicit feedback on changes needed.