Skip to content

Added Teleportation Task 1.1#1468

Merged
tcNickolas merged 6 commits into
microsoft:mainfrom
devikamehra:devikamehra/teleportation
May 22, 2024
Merged

Added Teleportation Task 1.1#1468
tcNickolas merged 6 commits into
microsoft:mainfrom
devikamehra:devikamehra/teleportation

Conversation

@devikamehra
Copy link
Copy Markdown
Contributor

Added first task for the teleportation kata (1.1)

As part of the migration - #1185

Copy link
Copy Markdown
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I left some comments, mostly along the lines of introducing the protocol and unifying the code with other katas.

Thank you!

Comment thread katas/content/teleportation/entangled_pair/Solution.qs Outdated
Comment thread katas/content/teleportation/index.md Outdated
Comment thread katas/content/teleportation/index.md Outdated
Comment thread katas/content/teleportation/index.md Outdated
Comment thread katas/content/teleportation/entangled_pair/index.md Outdated
Comment thread katas/content/teleportation/entangled_pair/Verification.qs Outdated
Comment thread katas/content/teleportation/index.md
Comment thread katas/content/teleportation/entangled_pair/index.md Outdated
Comment thread katas/content/teleportation/entangled_pair/solution.md Outdated
Comment thread katas/content/teleportation/index.md Outdated
@devikamehra devikamehra requested a review from tcNickolas May 21, 2024 11:29
Copy link
Copy Markdown
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and consistent with the final version of Superdense Coding kata, so should work well together. I have a few minor comments on whitespace and operation naming, but I can apply them myself before merging.

Thank you!

Comment thread katas/content/teleportation/entangled_pair/index.md Outdated
Comment thread katas/content/teleportation/Common.qs Outdated
Comment thread katas/content/teleportation/entangled_pair/Verification.qs Outdated
Comment thread katas/content/teleportation/entangled_pair/Verification.qs Outdated
Comment thread katas/content/index.json Outdated
@tcNickolas tcNickolas enabled auto-merge May 22, 2024 02:04
@devikamehra
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@tcNickolas tcNickolas added this pull request to the merge queue May 22, 2024
Merged via the queue into microsoft:main with commit ea10af9 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants