Add messages to samples in /samples/language#1509
Merged
Merged
Conversation
added 2 commits
May 10, 2024 20:45
goshua13
requested review from
DmitryVasilevsky,
cesarzc,
sezna,
swernli and
tcNickolas
as code owners
goshua13
commented
May 11, 2024
Contributor
|
I think if what happens has no visible effect (like qubit allocation) or is trivial (integer initialization) we don't need a message for that. My main desire is to show results of operations that are not trivial, since we did have a bug in one of the comments indicating the value of an array obtained using slicing, but not to annotate every line. |
Co-authored-by: Manvi-Agrawal <40084144+Manvi-Agrawal@users.noreply.github.com>
Co-authored-by: Manvi-Agrawal <40084144+Manvi-Agrawal@users.noreply.github.com>
tcNickolas
suggested changes
May 20, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks good, just two small comments.
Thank you!
added 2 commits
May 20, 2024 19:15
tcNickolas
approved these changes
May 21, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks great, just one message that is not necessary.
Thank you!
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
tcNickolas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1470