Add Measurements task 2.1 to Distinguishing States Kata#1518
Merged
Conversation
JPark1023
requested review from
DmitryVasilevsky,
billti,
cesarzc,
sezna,
swernli and
tcNickolas
as code owners
billti
reviewed
May 14, 2024
billti
reviewed
May 14, 2024
billti
reviewed
May 14, 2024
billti
reviewed
May 14, 2024
tcNickolas
suggested changes
May 22, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks good, and testing works nicely. I left some minor formatting comments
Thank you!
Contributor
|
You'll also need to add this kata to the list at index.json temporarily, so that CI builds validate it, and I'll remove it from the list before merging. I do this locally when testing this change, but it's better to let CI validate it as well |
tcNickolas
approved these changes
May 26, 2024
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks great! I'll remove the kata from the list and merge it once the CI is done
Thank you!
tcNickolas
reviewed
May 26, 2024
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Common.qs, media folder, zero-plus folder containing task and updated index
Resolves part of #1185