Skip to content

[Unitary hack] Add doc for internal AND#1580

Merged
minestarks merged 10 commits into
microsoft:mainfrom
Manvi-Agrawal:uh/and-doc
Jun 7, 2024
Merged

[Unitary hack] Add doc for internal AND#1580
minestarks merged 10 commits into
microsoft:mainfrom
Manvi-Agrawal:uh/and-doc

Conversation

@Manvi-Agrawal
Copy link
Copy Markdown
Contributor

@Manvi-Agrawal Manvi-Agrawal commented May 29, 2024

Fixes #1212.
image

@Manvi-Agrawal Manvi-Agrawal marked this pull request as ready for review May 29, 2024 14:41
Copy link
Copy Markdown
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! An additional recommendation for the API that should be included in the documentation is the assumption that when the normal/non-adjoint specialization is called the target qubit is expected to be in the zero or ground state. I'm not quite sure how to phrase that guidance, exactly, but I think it's worth finding a way to include that in the Summary section.

@Manvi-Agrawal
Copy link
Copy Markdown
Contributor Author

Manvi-Agrawal commented May 29, 2024

@swernli thanks for your review. I have update documentation and updated PR description as per your feedback.

The previous CI run failed on integration test(https://github.com/microsoft/qsharp/actions/runs/9281069142) and it seems unrelated, so I merged latest main.

Comment thread library/std/intrinsic.qs Outdated
Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>
Comment thread library/std/intrinsic.qs Outdated
@swernli
Copy link
Copy Markdown
Collaborator

swernli commented May 30, 2024

Looks like the change to the stdlib made some debugger tests fail because they confirm the line number that the debugger breaks into. Since the file contents changed, the line numbers have to be updated. A little annoying but an expected consequence of the change.

@Manvi-Agrawal
Copy link
Copy Markdown
Contributor Author

Looks like the change to the stdlib made some debugger tests fail because they confirm the line number that the debugger breaks into. Since the file contents changed, the line numbers have to be updated. A little annoying but an expected consequence of the change.

Thanks @swernli for looking into this. I have updated the failing IT based on CI build failures. Do you know how can I run Q# Debugger Tests suite locally?

  • Current, Set Language back to Python IT times out for me. I could find something to the effect of node --test --test-name-pattern="superdense_coding kata is valid" which I used for validating kata locally, which additionally ran few ITs after kata validating, so I was okay with that. But now using node --test --test-name-pattern="Step into standard lib" doesnt help me because of timeout of Set Language back to Python.

  • I tried looking out for VScode extensions to help with typescript testing, couldnt find any surprisingly, and I think I am definitely missing something here because Typescipt is quite often used in VsCode.

@swernli
Copy link
Copy Markdown
Collaborator

swernli commented May 30, 2024

To run the integration tests, you should be able to use the same python build script, but pass an additional flag:
python build.py --integration-tests

@Manvi-Agrawal
Copy link
Copy Markdown
Contributor Author

Thanks @swernli , the integration tests are passing locally for me now.

@Manvi-Agrawal
Copy link
Copy Markdown
Contributor Author

@minestarks could you please help with code owner approval

@Manvi-Agrawal
Copy link
Copy Markdown
Contributor Author

@swernli , @minestarks , @tcNickolas , could you please merge this PR since I have the required approvals.

@minestarks
Copy link
Copy Markdown
Member

@Manvi-Agrawal I will merge this PR as soon as the main branch is reopened after our next release (soon)!

@minestarks minestarks added this pull request to the merge queue Jun 7, 2024
Merged via the queue into microsoft:main with commit dec8db0 Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add three qubit AND operation to public API

3 participants