Fix display of CCX in a Circuit#1685
Merged
Merged
Conversation
A CCX is currently displayed as a controlled-controlled-CNOT instead of a controlled-controlled-X. This commit fixes this.
minestarks
approved these changes
Jun 30, 2024
swernli
approved these changes
Jun 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Toffoli/CCX in Q# code is currently displayed by the circuit generation code as a controlled-controlled-CNOT instead of a controlled-controlled-X.
I tried to add a test for this, but I'm not sure if I added it in the right place.
Testing
Ran
cargo testandpytest(including the integration tests dependent on qir-runner and pyqir)Also manually tested with this script:
which originally printed out:
but now it prints out the following as expected: