Merged
Conversation
ConradJohnston
requested review from
DmitryVasilevsky,
ScottCarda-MS,
billti,
idavis,
ivanbasov,
minestarks and
swernli
as code owners
billti
approved these changes
Oct 6, 2025
idavis
requested changes
Oct 7, 2025
Collaborator
idavis
left a comment
idavis
left a comment
There was a problem hiding this comment.
The mimalloc code is a vendored version of an external library and shouldn't be edited except to update the dependency. Please revert changes to this folder.
Tidying up some spelling errors in comments, error messages, etc.
ConradJohnston
force-pushed
the
fix/spelling-cleanup
branch
from
e541bb5 to
a1767c0
Compare
idavis
approved these changes
Oct 7, 2025
Contributor
Author
Great spot, thank you. Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spotted some spelling errors in comments, error messages, etc.
This PR tidies them up.
The majority of typo fixes are in comments and so should be harmless.
One is in the output JSON format generated by resource estimation. This typo is in the value of a
descriptionkey and so is unlikely to be matched downstream by a consumer.Some typos are in error messages - this may break error handling downstream, if an exact string is tested for. I'd still advocate for correct spelling being the expected condition.