Enable implementation of prune_error_budget in custom estimation API#2737
Merged
Enable implementation of prune_error_budget in custom estimation API#2737
prune_error_budget in custom estimation API#2737Conversation
msoeken
requested review from
billti,
idavis,
ivanbasov,
minestarks and
swernli
as code owners
ivanbasov
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the
prune_error_budgetfunction from theOverheadto the custom Python classes that can be used withestimate_custom. The function does not need to be implemented. If it is provided, it can change thebudgetvalue to tune the error budget based on the algorithm input. The signature is changed to return aResultin order to catch possible Python errors and a new test cases is added to check the behavior in presence and absence of this function.