Conversation
idavis
requested review from
DmitryVasilevsky,
billti,
minestarks and
swernli
as code owners
Closed
idavis
force-pushed
the
iadavis/qiskit-2.0-support
branch
from
1393ced to
a20779d
Compare
swernli
reviewed
Oct 29, 2025
swernli
reviewed
Oct 29, 2025
swernli
reviewed
Oct 29, 2025
swernli
approved these changes
Oct 29, 2025
Collaborator
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
A few minor comments and nitpicks, but otherwise a much more scoped update that I was worried it would be!
Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>
Collaborator
Author
|
@microsoft-github-policy-service rerun |
billti
reviewed
Oct 30, 2025
billti
approved these changes
Oct 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
billti
pushed a commit
that referenced
this pull request
Nov 14, 2025
Closes #2486 This work introduces a breaking change effectively removing the `QirTarget` class based on issues and doc updates from Qiskit, see Qiskit/qiskit#15142 (comment) . PR Summary: Qiskit 2.x enablement - Broadened optional qiskit dependency ranges (pyproject.toml, qdk_package/pyproject.toml) so our pip and meta packages install with either Qiskit `[1.22, 2.0)` or `[2.0,3.0)`. - Refactored QirTarget into a factory (create_target) and updated `BackendBase` to request it, matching the Qiskit 2.0 Target API and allowing callers to inject a qubit count without subclassing. - Hardened integration and resource-estimator tests for multi-version runs: install requirements once, then execute each suite against both Qiskit major versions, capture version-dependent logical-count baselines, and rely on `skip_transpilation` where needed. - Adjusted notebook automation so only notebooks with “qiskit” in their filename execute under the version matrix; other samples still run once per build. - Trimmed shared test requirements (Qiskit now supplied via the build matrix) and touched the Qiskit sample notebook metadata to keep it aligned. --------- Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2486
This work introduces a breaking change effectively removing the
QirTargetclass based on issues and doc updates from Qiskit, see Qiskit/qiskit#15142 (comment) .PR Summary: Qiskit 2.x enablement
[1.22, 2.0)or[2.0,3.0).BackendBaseto request it, matching the Qiskit 2.0 Target API and allowing callers to inject a qubit count without subclassing.skip_transpilationwhere needed.