Adjust over-large address register in Unlookup#2762
Closed
Conversation
|
Change in memory usage detected by benchmark. Memory Report for 3a60f66
|
DmitryVasilevsky
approved these changes
Oct 30, 2025
|
|
||
| // Apply phase lookup to correct phases in the address register | ||
| PhaseLookup(address, phaseData); | ||
| PhaseLookup(address[...addressBitsNeeded - 1], phaseData); |
Contributor
There was a problem hiding this comment.
We probably need a test case for this.
billti
pushed a commit
that referenced
this pull request
Oct 30, 2025
Unit test for #2762 fix. Address register is allowed to be larger than needed to address data. Fails before the fix, passes after fix. Includes the fix commit. --------- Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com> Co-authored-by: Dmitry Vasilevsky <dmitryv@microsoft.com>
Member
|
Merged as part of #2765 |
billti
pushed a commit
that referenced
this pull request
Nov 14, 2025
Unit test for #2762 fix. Address register is allowed to be larger than needed to address data. Fails before the fix, passes after fix. Includes the fix commit. --------- Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com> Co-authored-by: Dmitry Vasilevsky <dmitryv@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We check in PhaseLookup whether the number of data bit-strings matches the address length. However, the address register may be larger than necessary (which is not a problem), in which case we need to shrink it to the required size. The computation of the required size and its validation is already present in the
Unlookupoperation.