[Language Service] Fix project path on notebooks when running on Windows#2872
Merged
orpuente-MS merged 7 commits intomainfrom Jan 22, 2026
Merged
Conversation
orpuente-MS
requested review from
billti,
idavis and
minestarks
as code owners
orpuente-MS
commented
Jan 21, 2026
billti
reviewed
Jan 21, 2026
minestarks
reviewed
Jan 22, 2026
minestarks
approved these changes
Jan 22, 2026
Member
|
There are still issues in remote VS Code scenarios such as WSL, Codespaces, VS Code Web . But that's not new with this PR, nor does this PR make that issue worse. @orpuente-MS and I discussed a possible fix for the remote scenarios. (Using the scheme from the .ipynb file, and "mashing it up" with the local OS path retrieved from Python). I'm still approving this PR since it fixes the intended case (local Windows) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2866