Magnets: modified Trotter expansion classes and added Cirq output.#3040
Merged
brad-lackey merged 2 commits intofeature/qrefrom Mar 23, 2026
Merged
Magnets: modified Trotter expansion classes and added Cirq output.#3040brad-lackey merged 2 commits intofeature/qrefrom
brad-lackey merged 2 commits intofeature/qrefrom
Conversation
msoeken
approved these changes
Mar 23, 2026
| }, | ||
| ) | ||
| oper = cirq.PauliStringPhasor( | ||
| pauli, exponent_neg=time / 3.141592653589793 |
Member
There was a problem hiding this comment.
Suggest to replace constant with math.pi.
| """Iterate over ``(time, term_index)`` entries for this step.""" | ||
| return iter(self.terms) | ||
|
|
||
| def cirq(self, model: Model) -> cirq.Circuit: |
Member
There was a problem hiding this comment.
Are there simulation tests for the circuit to make sure all the arguments to PauliStringPhasor are correct (signs and factors).
Author
There was a problem hiding this comment.
I have a separate Jupyter notebook I use for testing. The Cirq "PauliStringPhasor" does use the correct angles after normalizing it appropriately (hence the pi). This implementation does introduce a global phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New features for Trotter expansions.