Use separate browser/node entrypoints instead of runtime environment detection#3121
Merged
minestarks merged 3 commits intomainfrom Apr 15, 2026
Merged
Use separate browser/node entrypoints instead of runtime environment detection#3121minestarks merged 3 commits intomainfrom
minestarks merged 3 commits intomainfrom
Conversation
ScottCarda-MS
approved these changes
Apr 15, 2026
joao-boechat
approved these changes
Apr 15, 2026
- Remove redundant browser.ts wrapper - Update package.json exports to use main.js for browser - Update main.ts header comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes us back to splitting the package entrypoint using the
exportsfield's conditional"browser"/"node"conditions:Workerwithtype: "classic")globalThis.Workerviaweb-workerand callssetWorkerType("module")before re-exporting main.tsThe
isBrowserruntime detection is removed entirely. Instead, the worker type is passed explicitly as a parameter tocreateProxy.