Use platform-agnostic worker interface instead of web-worker dependency#3153
Merged
Merged
Conversation
minestarks
reviewed
Apr 23, 2026
minestarks
approved these changes
Apr 23, 2026
Member
minestarks
left a comment
There was a problem hiding this comment.
LGTM! Please test thoroughly (including maybe running multiplatform tests?) before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
web-workernpm polyfill with a platform-specific worker adapter layer. Each platform (browser, Node.js) now provides its ownIWorkerHostandIWorkerSelfimplementation, eliminating the third-party dependency while giving the shared code a single, clean interface for worker communication.What changed
web-workeroptional dependency and theglobalThis.Workerpolyfill innode.tssetWorkerType/workerType— no longer needed since each adapter handles worker creation internallysrc/workers/adapters/withIWorkerHost(main→worker) andIWorkerSelf(worker→main) interfacesBrowserWorkerHostandNodeWorkerHostimplementationssrc/browser.tsentry point (mirrorsnode.ts)package.jsonexports to usebrowser.tsfor browser buildsaddEventListener("message", ...)orself.postMessage(...)directly — they use theWorkerSelfglobalArchitecture
Before: polyfill the browser API into Node
Workerglobal usingweb-workeraddEventListener,self.postMessage)workerTypetoggled between"classic"and"module"After: each platform provides its own adapter
IWorkerHostandIWorkerSelfinterfacesWorkerSelfis bootstrapped into the worker thread via blob URL (browser) or data URL (Node) before the worker script runs