QREv3 neutral atom models#3198
Conversation
brad-lackey
requested review from
billti,
idavis,
minestarks and
msoeken
as code owners
| encoding=Encoding.PHYSICAL, | ||
| arity=1, | ||
| time=0, | ||
| error_rate=0.00001, |
There was a problem hiding this comment.
Should this be configurable? It should also have a comment to explain why we currently do not set the error rate to 0.
There was a problem hiding this comment.
This is a hack so that we can export the T gate without having to build a ISATransform wrapper around NeutralAtom. Once the magic state factories can handle T-gate error rates of 0, we can revert this back to zero.
| encoding=Encoding.PHYSICAL, | ||
| arity=1, | ||
| time=2 * self.handoff_time, | ||
| error_rate=1e-4, |
There was a problem hiding this comment.
Should this be configurable? Is this value ever used or are we only using the move instruction to provide timing information?
There was a problem hiding this comment.
It is, via the handoff_time keyword. The details of the move are handled at a higher level of the stack, so the only thing I can think of at the platform level for the PHYSICAL_MOVE is the handoff time.
There was a problem hiding this comment.
I was referring to the hard coded error rate of 1e-4
NeutralAtom class: architecture for a generic neutral atom platform. SurfaceCodeLowMove class: a variant of the surface code that does syndrome extraction with local moves. Added properties: ACCELERATION, VELOCITY, ATOM_SPACING to support neutral atom platforms. This fixes merge issues in microsoft#3198 after microsoft#3192. It does not include updates to property handling and property constraints, which is noted in microsoft#3210.
2 participants
NeutralAtom class: architecture for a generic neutral atom platform.
SurfaceCodeLowMove class: a variant of the surface code that does syndome extraction with local moves.
Added properties: ACCELERATION, VELOCITY, ATOM_SPACING to support neutral atom platforms.