Include locals in the completion list#880
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
minestarks
changed the title
minestarks
force-pushed
the
minestarks/completion-locals
branch
from
034c5fc to
2a03df1
Compare
minestarks
force-pushed
the
minestarks/completion-locals
branch
from
2a03df1 to
2920ab0
Compare
minestarks
requested review from
ScottCarda-MS,
billti,
cesarzc,
idavis and
swernli
as code owners
sezna
reviewed
Dec 5, 2023
sezna
reviewed
Dec 5, 2023
minestarks
commented
Dec 7, 2023
minestarks
commented
Dec 7, 2023
minestarks
commented
Dec 7, 2023
swernli
reviewed
Dec 7, 2023
swernli
reviewed
Dec 7, 2023
swernli
approved these changes
Dec 7, 2023
idavis
approved these changes
Dec 8, 2023
minestarks
commented
Dec 8, 2023
…rosoft/qsharp into minestarks/completion-locals
…tarks/completion-locals
ScottCarda-MS
approved these changes
Dec 8, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
#880 added support for locals in completion list. What was still missing in the Monaco playground and VS Code extension is mapping to the relevant icon. Before: <img width="607" alt="Bildschirmfoto 2024-02-02 um 15 59 11" src="https://github.com/microsoft/qsharp/assets/1710369/2759d98c-e528-4510-9fb0-b25e145e5032"> After: <img width="538" alt="Bildschirmfoto 2024-02-02 um 15 58 35" src="https://github.com/microsoft/qsharp/assets/1710369/d5e043b5-fbb5-4335-95cb-57655cf19b4d">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During name resolution, we now collect all the scopes and locals in the program into a table that can be used later for completion lists.