fix: incorrect index implementation in FileCalendarStorage#2195
Merged
SunsetWolf merged 1 commit intomicrosoft:mainfrom Apr 21, 2026
Merged
fix: incorrect index implementation in FileCalendarStorage#2195SunsetWolf merged 1 commit intomicrosoft:mainfrom
SunsetWolf merged 1 commit intomicrosoft:mainfrom
Conversation
Collaborator
|
Hi, @Srujanrana07 , Thanks for the contribution! Really appreciate your work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect behavior in
FileCalendarStorage.index()where a valuepresent in the calendar could still raise an IndexError.
The previous implementation used NumPy comparison on a Python list,
which resulted in incorrect boolean evaluation and failure to locate
existing values.
This change replaces it with Python’s built-in
list.index()method,ensuring correct lookup behavior.
Motivation and Context
Fixes #2192
The current implementation:
fails because calendar is a Python list, and
list == valuereturnsa single boolean instead of an element-wise comparison.
This leads to:
This fix aligns behavior with Python's standard
list.index().How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Types of changes