fix: allow disabling LightGBM early stopping#2228
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
early_stopping()callback creation whenearly_stopping_roundsresolves toNoneFixes #2226
To verify
python -m py_compile qlib\contrib\model\gbdt.py qlib\contrib\model\highfreq_gdbt_model.py tests\model\test_lightgbm_early_stopping.pypython -m black --check --target-version py313 --fast tests\model\test_lightgbm_early_stopping.pygit diff --checkLocal blocker
I tried
python -m pytest tests\model\test_lightgbm_early_stopping.py -q, but this Windows checkout could not import qlib before collection because the Cython extensionqlib.data._libs.rollingwas not built.pip install -e .then failed while compiling that extension because MSVC could not findio.hfrom the local Python/Windows SDK setup. The test itself is included for CI where qlib's extension build is available.