Release-react command doesn't invoke "converting JS bundle to byte code via hermes.."

[hengki01]

Recently, I try to migrate from JSC to hermes-engine for my RN app. Released build (using hermes) has been successfully created.

(./android/app/build.gradle)

I expect for releasing hermes-generated bytecode instead of JS bundle, but release command from appcenter cli didn't invoke JS bundle to bytecode step.

appcenter codepush release-react -a hengki/testingAndroidExplorer -d Staging -t '*'

Expected Behavior

'Converting JS Bundle to byte code via Hermes, running command:' invoked after writing bundle output finished. (based on microsoft/appcenter-cli#627)

Actual Behavior

Releasing update contents to CodePush, instead of 'Converting JS Bundle to byte code via Hermes..."

Environment

• react-native-code-push version: 6.2.0
• react-native version: 0.61.5
• appcenter version: 2.4.0
• OS: macOS Catalina 10.15.4

[naum43312016]

Hi, @hengki01 we have the same problem, did you find a solution for this?

[hengki01]

@naum43312016
It's been a long time ago, actually I don't really remember how I could solve the problem.
As far as I can recall, I did ./gradlew clean and restart my machine.

React native code push library definitely works with Hermes, since I heavily use it in my RN project up until now.

[naum43312016]

@hengki01 thanks

[MouliMohanN]

Hey @naum43312016 ,

You need to make sure enableHermes: true to be the in the exact format.

If you have the flag in different format like -

1. enableHermes:true
2. enableHermes : true

• It won't work.

I've explained the issue and fix in detail here - https://medium.com/@moulimohann/reactnative-app-becomes-slow-after-codepush-how-did-i-fix-951f913a5084

[eeslamadelll]

So for me, I'm using NX for our monorepo setup and I had this issue for days and I decided to look into the appcenter-cli code.

and at appcenter-cli/dist/commands/codepush/lib/react-native-utils.js i found this function

function getHermesOSExe() {
  const react63orAbove =
    semver_1.compare(
      semver_1.coerce(getReactNativeVersion()).version,
      "0.63.0",
    ) !== -1;
  const hermesExecutableName = react63orAbove ? "hermesc" : "hermes";
  switch (process.platform) {
    case "win32":
      return hermesExecutableName + ".exe";
    default:
      return hermesExecutableName;
  }
}

which compares the react native version against 0.63.0 because of a change in the hermes command name

and in the monorepo setup, the appcenter-cli was looking for the react-native version inside the package.json for the project and it was like the following

"dependencies": {
    "react-native": "*",
    ....
}

and the reason of this is, in monorepos you have a global package.json file and all projects can share the packages in there
but with react native you need to have a sub package.json with the native libraries you use in your app so auto-linking can as expected.

and changing my package.json and include the react-native version, everything related to appcenter and codepush start to work as expected

"dependencies": {
    "react-native": "0.64.0",
    ....
}

[burakkgunduzz]

@engeslamadell solution also worked for me (I am also using nx and in a monorepo setup). However, my colleagues with exactly the same setup , repo and versions (appcenter-cli etc) does not have to specify RN version in package.json and their codepush works out of the box. What could be the factor here I wonder?

[eeslamadelll]

@burakkgunduzz not sure exactly, but I think they somehow configured their workspace to look in the root package.json, not the sub one, that way appcenter knows the version and can make decisions.