Query update with current package#3
Conversation
HybridMobileDeploy.ios.js
Outdated
There was a problem hiding this comment.
put spacing between if and opening paranthesis, similarly for else and braces.. that is our coding guidelines.
feedback throughout the code.
If someone has a link to the coding guideline page, that would be great for Geoffery.
HybridMobileDeploy.ios.js
Outdated
There was a problem hiding this comment.
Reduce redundancy by combining logic;
var defaultPackage = {appVersion: configuration.appVersion};
if (!err && localPackage !== null && localPackage.appVersion === configuration.appVersion) {
defaultPackage = localPackage;
} else if (err) {
console.log(err);
}
sdk.queryUpdateWithCurrentPackage(defaultPackage, callback);
HybridMobileDeploy.ios.js
Outdated
There was a problem hiding this comment.
I should have mentioned this before, final change:
if (!err && localPackage && localPackage...)
checking this way verifies localPackage against null and undefined.. dont need an explicit null check.
|
LGTM! You should wait on @itsananderson to signoff for the objective C changes.. |
|
The file |
|
Sorry for the delayed review. LGTM once you remove the temp file. |
…d_apps Support for brownfield apps
Edited the code to