Use RCTUISwitch shim in Paper (RCTSwitch) #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Dec 13, 2022
Saadnajmi
changed the title
mischreiber
reviewed
Dec 15, 2022
mischreiber
approved these changes
Dec 15, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* Use RCTUISwitch for paper * More diffs removed * Ue typedef * Update RCTUIKit.h * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
While implementing Fabric for React Native macOS, we created a few new shim classes in RCTUIKit that we could potentially use in our paper implementation as well. This change extends the simple
RCTUISwitchshim to implement what we need for it to work on Paper (aka, use it in RCTSwitch). The end result is a few less macOS diffs and overall cleaner code in my opinion =)Changelog
[macOS] [Chenged] - Use RCTUISwitch shim for RCTSwitch
Test Plan
Test page still works fine.
Screen.Recording.2022-12-14.at.1.07.35.PM.mov