Skip to content

Conversation

HeyImChris
Copy link

@HeyImChris HeyImChris commented Oct 15, 2019

Include RCTBackedTextInputViewProtocol and RCTBackedTextInputDelegate in RCTText as they weren't getting built into the RCTTextLibrary, which is necessary for Polyester's consumption.

Please select one of the following

  • I am making a fix / change for the macOS implementation of react-native

These headers must be included in the RCTText library so Polyester classes can import them.

Focus areas to test

It must get pushed into github, get pushed to SDX-Platform, and then we can see if there are any other issues hiding behind this header issue.

Microsoft Reviewers: Open in CodeFlow

… getting built into the RCTTextLibrary, which is necessary for Polyester
@tom-un tom-un merged commit adf59b9 into master Oct 15, 2019
@acoates-ms acoates-ms deleted the chrishog/fb60mergePLYIntegration branch October 21, 2019 21:07
NickGerleman pushed a commit to NickGerleman/react-native that referenced this pull request Jun 11, 2025
Summary:
Pull Request resolved: facebook#51963

Changelog: [Internal] - Update `react-native/debugger-frontend` from 41bf86b...68cfd0a

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@41bf86b...68cfd0a).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [68cfd0ae8](facebook/react-native-devtools-frontend@68cfd0ae8) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T19:20:10+01:00 | [feat: restore Performance landing page (microsoft#179)](facebook/react-native-devtools-frontend@68cfd0ae8) |
| [bc3bd7f55](facebook/react-native-devtools-frontend@bc3bd7f55) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T12:19:18+01:00 | [chore: hide unsupported Detached elements memory profiling option (microsoft#178)](facebook/react-native-devtools-frontend@bc3bd7f55) |
| [1f9eb6528](facebook/react-native-devtools-frontend@1f9eb6528) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T10:05:12+01:00 | [ci: minor naming and formatting fixes (microsoft#177)](facebook/react-native-devtools-frontend@1f9eb6528) |
| [42526665c](facebook/react-native-devtools-frontend@42526665c) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T10:02:00+01:00 | [ci: split build workflow (microsoft#176)](facebook/react-native-devtools-frontend@42526665c) |
| [7307e9532](facebook/react-native-devtools-frontend@7307e9532) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T19:43:08+01:00 | [chore: added lint GitHub workflow (microsoft#174)](facebook/react-native-devtools-frontend@7307e9532) |
| [8d613dd1c](facebook/react-native-devtools-frontend@8d613dd1c) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T19:42:53+01:00 | [chore: more instructions on repository syncing (microsoft#173)](facebook/react-native-devtools-frontend@8d613dd1c) |
| [d449be9e2](facebook/react-native-devtools-frontend@d449be9e2) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T18:48:14+01:00 | [Merge pull request microsoft#172 from facebook/repo-sync-7103](facebook/react-native-devtools-frontend@d449be9e2) |

Reviewed By: huntie

Differential Revision: D76455694

fbshipit-source-id: e44a016afe25ae62d72cf4b02e620ba166a9eeb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants