Skip to content

Adding metro-config dependency #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2019
Merged

Adding metro-config dependency #176

merged 2 commits into from
Oct 17, 2019

Conversation

BarinderGrewal
Copy link

@BarinderGrewal BarinderGrewal commented Oct 17, 2019 •
edited
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Issue
Creation of RNTester app bundle is failing in sdx-platform even though it is getting created in MS React-Native GitHub repo.

Fix
Added dependency of metro-config in react-native package.json to resolve this issue.

Microsoft Reviewers: Open in CodeFlow

@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against fff3919

acoates-ms
acoates-ms requested changes Oct 17, 2019
View reviewed changes
Copy link
Collaborator

@acoates-ms acoates-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version should align with the rest of metro.

@ghost ghost removed the Needs: Author Feedback label Oct 17, 2019
@BarinderGrewal
Copy link
Author

I think the version should align with the rest of metro.

Updated the version

@acoates-ms acoates-ms merged commit ae3428e into microsoft:master Oct 17, 2019
NickGerleman pushed a commit to NickGerleman/react-native that referenced this pull request Jun 11, 2025
@hoxyq @facebook-github-bot
Update debugger-frontend from 41bf86b...68cfd0a (facebook#51963)
0dd3f80 
Summary:
Pull Request resolved: facebook#51963

Changelog: [Internal] - Update `react-native/debugger-frontend` from 41bf86b...68cfd0a

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@41bf86b...68cfd0a).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [68cfd0ae8](facebook/react-native-devtools-frontend@68cfd0ae8) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T19:20:10+01:00 | [feat: restore Performance landing page (microsoft#179)](facebook/react-native-devtools-frontend@68cfd0ae8) |
| [bc3bd7f55](facebook/react-native-devtools-frontend@bc3bd7f55) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T12:19:18+01:00 | [chore: hide unsupported Detached elements memory profiling option (microsoft#178)](facebook/react-native-devtools-frontend@bc3bd7f55) |
| [1f9eb6528](facebook/react-native-devtools-frontend@1f9eb6528) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T10:05:12+01:00 | [ci: minor naming and formatting fixes (microsoft#177)](facebook/react-native-devtools-frontend@1f9eb6528) |
| [42526665c](facebook/react-native-devtools-frontend@42526665c) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T10:02:00+01:00 | [ci: split build workflow (microsoft#176)](facebook/react-native-devtools-frontend@42526665c) |
| [7307e9532](facebook/react-native-devtools-frontend@7307e9532) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T19:43:08+01:00 | [chore: added lint GitHub workflow (microsoft#174)](facebook/react-native-devtools-frontend@7307e9532) |
| [8d613dd1c](facebook/react-native-devtools-frontend@8d613dd1c) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T19:42:53+01:00 | [chore: more instructions on repository syncing (microsoft#173)](facebook/react-native-devtools-frontend@8d613dd1c) |
| [d449be9e2](facebook/react-native-devtools-frontend@d449be9e2) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T18:48:14+01:00 | [Merge pull request microsoft#172 from facebook/repo-sync-7103](facebook/react-native-devtools-frontend@d449be9e2) |

Reviewed By: huntie

Differential Revision: D76455694

fbshipit-source-id: e44a016afe25ae62d72cf4b02e620ba166a9eeb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BarinderGrewal @pull-bot @acoates-ms @barindervir