Changes required for Polyester and ReactNativeHost #177
Conversation
| return getTypeface(fontFamilyName, style, 0, assetManager); | ||
| } | ||
|
|
||
| public @Nullable Typeface getTypeface( |
There was a problem hiding this comment.
Can we instead extend the existing addCustomFont method, to have another override which takes a Typeface directly? That way we are not introducing another font loading path. -- it'll be a smaller diff from the OSS version, and we can look at upstreaming that change to OSS?
There was a problem hiding this comment.
Sure. I will have a look at this.
There was a problem hiding this comment.
This is what I understood from the flow.
If I add an overridden addCustomFont method which accepts Typeface, this typeface should also be created for which we require our createTypeface method. And in addCustomFont we will have to add this typeface to map(cache) for faster access later. Whenever any component needs to apply this typeface, they will have to use getTypeface method which will return the typeface from the map. This flow will not remove the methods we added but instead add one more method to this class.
Please correct me if wrong as I may not have understood your point properly.
|
Obviously stale... |
Summary: Pull Request resolved: facebook#51963 Changelog: [Internal] - Update `react-native/debugger-frontend` from 41bf86b...68cfd0a Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@41bf86b...68cfd0a). ### Changelog | Commit | Author | Date/Time | Subject | | ------ | ------ | --------- | ------- | | [68cfd0ae8](facebook/react-native-devtools-frontend@68cfd0ae8) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T19:20:10+01:00 | [feat: restore Performance landing page (microsoft#179)](facebook/react-native-devtools-frontend@68cfd0ae8) | | [bc3bd7f55](facebook/react-native-devtools-frontend@bc3bd7f55) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T12:19:18+01:00 | [chore: hide unsupported Detached elements memory profiling option (microsoft#178)](facebook/react-native-devtools-frontend@bc3bd7f55) | | [1f9eb6528](facebook/react-native-devtools-frontend@1f9eb6528) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T10:05:12+01:00 | [ci: minor naming and formatting fixes (microsoft#177)](facebook/react-native-devtools-frontend@1f9eb6528) | | [42526665c](facebook/react-native-devtools-frontend@42526665c) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-11T10:02:00+01:00 | [ci: split build workflow (microsoft#176)](facebook/react-native-devtools-frontend@42526665c) | | [7307e9532](facebook/react-native-devtools-frontend@7307e9532) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T19:43:08+01:00 | [chore: added lint GitHub workflow (microsoft#174)](facebook/react-native-devtools-frontend@7307e9532) | | [8d613dd1c](facebook/react-native-devtools-frontend@8d613dd1c) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T19:42:53+01:00 | [chore: more instructions on repository syncing (microsoft#173)](facebook/react-native-devtools-frontend@8d613dd1c) | | [d449be9e2](facebook/react-native-devtools-frontend@d449be9e2) | Ruslan Lesiutin (rdlesyutin@gmail.com) | 2025-06-10T18:48:14+01:00 | [Merge pull request microsoft#172 from facebook/repo-sync-7103](facebook/react-native-devtools-frontend@d449be9e2) | Reviewed By: huntie Differential Revision: D76455694 fbshipit-source-id: e44a016afe25ae62d72cf4b02e620ba166a9eeb9
3 participants
Please select one of the following
Changes required for Polyester and ReactNativeHost
Microsoft Reviewers: Open in CodeFlow